[ 
https://issues.apache.org/jira/browse/NIFI-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456748#comment-16456748
 ] 

ASF GitHub Bot commented on NIFI-5051:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2615#discussion_r184746728
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchLookupService.java
 ---
    @@ -0,0 +1,290 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.elasticsearch;
    +
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import org.apache.nifi.annotation.lifecycle.OnEnabled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.PropertyValue;
    +import org.apache.nifi.components.ValidationContext;
    +import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.controller.AbstractControllerService;
    +import org.apache.nifi.controller.ConfigurationContext;
    +import org.apache.nifi.expression.ExpressionLanguageScope;
    +import org.apache.nifi.lookup.LookupFailureException;
    +import org.apache.nifi.lookup.LookupService;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.reporting.InitializationException;
    +import org.apache.nifi.schemaregistry.services.SchemaRegistry;
    +import org.apache.nifi.serialization.SimpleRecordSchema;
    +import org.apache.nifi.serialization.record.MapRecord;
    +import org.apache.nifi.serialization.record.Record;
    +import org.apache.nifi.serialization.record.RecordField;
    +import org.apache.nifi.serialization.record.RecordFieldType;
    +import org.apache.nifi.serialization.record.RecordSchema;
    +import org.apache.nifi.serialization.record.SchemaIdentifier;
    +import org.apache.nifi.serialization.record.type.RecordDataType;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Optional;
    +import java.util.Set;
    +
    +public class ElasticSearchLookupService extends AbstractControllerService 
implements LookupService {
    +    public static final PropertyDescriptor CLIENT_SERVICE = new 
PropertyDescriptor.Builder()
    +        .name("el-rest-client-service")
    +        .displayName("Client Service")
    +        .description("An ElasticSearch client service to use for running 
queries.")
    +        .identifiesControllerService(ElasticSearchClientService.class)
    +        .required(true)
    +        .build();
    +    public static final PropertyDescriptor INDEX = new 
PropertyDescriptor.Builder()
    +        .name("el-lookup-index")
    +        .displayName("Index")
    +        .description("The name of the index to read from")
    +        .required(true)
    +        
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
    +        .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +        .build();
    +
    +    public static final PropertyDescriptor TYPE = new 
PropertyDescriptor.Builder()
    +        .name("el-lookup-type")
    +        .displayName("Type")
    +        .description("The type of this document (used by Elasticsearch for 
indexing and searching)")
    +        .required(false)
    +        
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
    +        .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +        .build();
    +
    +    public static final PropertyDescriptor SCHEMA_REGISTRY = new 
PropertyDescriptor.Builder()
    +        .name("el-lookup-schema-registry")
    +        .displayName("Schema Registry")
    +        .description("If specified, this avro schema will be used for all 
objects loaded from MongoDB using this service. If left blank, " +
    +                "the service will attempt to determine the schema from the 
results.")
    +        .required(false)
    +        .identifiesControllerService(SchemaRegistry.class)
    +        .build();
    +
    +    public static final PropertyDescriptor RECORD_SCHEMA_NAME = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    Now that #2661 has been merged, could you extend SchemaRegistryService 
instead of AbstractControllerService (which you'll still get as 
SchemaRegistryService's parent)? That way you'll have immediate access to the 
same properties and logic as other schema-registry-aware processors to give a 
consistent UX.


> Create a LookupService that uses ElasticSearch
> ----------------------------------------------
>
>                 Key: NIFI-5051
>                 URL: https://issues.apache.org/jira/browse/NIFI-5051
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Mike Thomsen
>            Assignee: Mike Thomsen
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to