Github user jvwing commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2704#discussion_r189164826
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/TestListS3.java
---
@@ -311,5 +312,10 @@ public void testGetPropertyDescriptors() throws
Exception {
assertTrue(pd.contains(ListS3.PREFIX));
assertTrue(pd.contains(ListS3.USE_VERSIONS));
assertTrue(pd.contains(ListS3.MIN_AGE));
+
assertTrue(pd.contains(ProxyConfigurationService.PROXY_CONFIGURATION_SERVICE));
+ assertTrue(pd.contains(ListS3.PROXY_HOST));
--- End diff --
Minor tweak: The check for PROXY_HOST and PROXY_HOST_PORT duplicates checks
above on lines 309-310. I believe this is why we add 5 lines of new
assertions, but the count of property descriptors only goes up by 3 from 17 to
20. It doesn't make any difference, really, but the math was bothering me.
---
