[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

[ijokarumawak]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/2704
  
    Added 3 more commits.
    
    1. Added proxy support to Azure processors.
    2. Adding more explicit Proxy spec check and doc. Due to the restrictions 
of underlying libraries, Proxy support spec varies. Based on the investigation 
summarized in this PR's description, I've used 4 labels to represent spec HTTP, 
HTTP_AUTH, SOCKS and SOCKS_AUTH.
    3. Incorporated review comments.
    
    Example screenshots:
    InvokeHTTP does not support SOCKS_AUTH, so if ProxyConfigurationService is 
configured with SOCKS and username/password, then it becomes invalid, but SOCKS 
without auth can be used:
    
![image](https://user-images.githubusercontent.com/1107620/40225356-c5e6a30c-5ac3-11e8-8bb4-9541144e6491.png)
    
    PostHTTP does not support SOCKS at all:
    
![image](https://user-images.githubusercontent.com/1107620/40225479-1e24b64e-5ac4-11e8-880c-bb7fbe0642a7.png)
    
    Not only validation, property description shows what proxy is supported:
    
![image](https://user-images.githubusercontent.com/1107620/40225514-37432408-5ac4-11e8-89df-654fcef8e8ef.png)
    
    SFTP processors are the only ones supporting all Proxy specs:
    
![image](https://user-images.githubusercontent.com/1107620/40225546-4a64dbda-5ac4-11e8-8eae-b421f0fdb585.png)
    
    
    
    
    



---