Github user bdesert commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190283975
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
---
@@ -237,7 +237,7 @@ public void setup() {
@Override
public void onPropertyModified(final PropertyDescriptor descriptor,
final String oldValue, final String newValue) {
--- End diff --
@ottobackwards , when a processor is invalid (customValidate returned
validation errors), we keep all the validationResults. Method 'customValidate'
just check if there are already errors - no need to validate again, just return
whatever is stored.
When any property is getting modified - these validation results may not be
accurate anymore, so we have to reset them. Once reset (onPropertyModified),
next call to customValidate will run full validation and set new errors if
found. So at any point we don't drop validation results for no reason. Am I
missing anything?
---
