Github user bdesert commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190286397
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
---
@@ -237,7 +237,7 @@ public void setup() {
@Override
public void onPropertyModified(final PropertyDescriptor descriptor,
final String oldValue, final String newValue) {
--- End diff --
@ottobackwards , regarding Set vs List. Validation Result supposed to be
Collection, so technically - any of them can be used. But consistency should
come with Set, as if you check super class AbstractConfigurableComponent, its
customValidate returns:
return Collections.emptySet();
So, I would say, we need to refactor ArrayList into Set, but then there
will be more potential regression impact. I'd recommend to keep it as is for
this PR/Jira, and have another ticket opened on cosmetic improvement to change
ArrayList to to some Set implementation during initialization. I hope it makes
sense.
---
