Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2738#discussion_r190618349
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/test/java/org/apache/nifi/hbase/TestHBase_1_1_2_ClientService.java
 ---
    @@ -119,9 +124,9 @@ public void testCustomValidate() throws 
InitializationException, IOException {
             // quorum, port, and znode, no conf file, should be valid
             service = new MockHBaseClientService(table, COL_FAM, 
kerberosPropsWithFile);
             runner.addControllerService("hbaseClientService", service);
    -        runner.setProperty(service, 
HBase_1_1_2_ClientService.ZOOKEEPER_QUORUM, "localhost");
    -        runner.setProperty(service, 
HBase_1_1_2_ClientService.ZOOKEEPER_CLIENT_PORT, "2181");
    -        runner.setProperty(service, 
HBase_1_1_2_ClientService.ZOOKEEPER_ZNODE_PARENT, "/hbase");
    +        runner.setProperty(service, 
HBase_1_1_2_ClientService.ZOOKEEPER_QUORUM, "${zk-quorum}");
    +        runner.setProperty(service, 
HBase_1_1_2_ClientService.ZOOKEEPER_CLIENT_PORT, "${zk-port}");
    --- End diff --
    
    yeah... good catch


---

Reply via email to