Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2760#discussion_r193132253
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java
 ---
    @@ -227,7 +226,10 @@ public void onTrigger(final ProcessContext context, 
final ProcessSession session
             List<FlowFile> flowFilesToTransfer = new LinkedList<>(flowFiles);
     
             final StringBuilder sb = new StringBuilder();
    -        final String baseUrl = 
trimToEmpty(context.getProperty(ES_URL).evaluateAttributeExpressions().getValue());
    +        final String baseUrl = 
context.getProperty(ES_URL).evaluateAttributeExpressions().getValue().trim();
    +        if (StringUtils.isEmpty(baseUrl)) {
    --- End diff --
    
    if baseUrl is empty should the exception message be that "Elasticsearch URL 
evaluates to empty"  or something?  Your message is always going to be "... not 
valid: " since baseUrl will be empty.



---

Reply via email to