Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2760#discussion_r193183815
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecordIT.java
 ---
    @@ -227,6 +227,29 @@ public void testBadIndexName() throws Exception {
             runner.assertTransferCount(PutElasticsearchHttpRecord.REL_SUCCESS, 
0);
         }
     
    +    @Test
    +    public void testIndexNameWithJsonChar() throws Exception {
    +        // Undo some stuff from setup()
    +        runner.setProperty(PutElasticsearchHttpRecord.INDEX, 
"people}test");
    +        runner.setProperty(PutElasticsearchHttpRecord.TYPE, "person");
    +        recordReader.addRecord(1, new MapRecord(personSchema, new 
HashMap<String,Object>() {{
    +            put("name", "John Doe");
    +            put("age", 48);
    +            put("sport", null);
    +        }}));
    +
    +        List<Map<String, String>> attrs = new ArrayList<>();
    +        Map<String, String> attr = new HashMap<>();
    +        attr.put("doc_id", "1");
    +        attrs.add(attr);
    +
    +        runner.enqueue("");
    +        runner.run(1, true, true);
    +        runner.assertTransferCount(PutElasticsearchHttpRecord.REL_FAILURE, 
0);
    +        runner.assertTransferCount(PutElasticsearchHttpRecord.REL_RETRY, 
0);
    --- End diff --
    
    Should this succeed or fail?


---

Reply via email to