[
https://issues.apache.org/jira/browse/NIFI-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502367#comment-16502367
]
Matt Gilman commented on NIFI-3217:
-----------------------------------
[~alopresto] [~JPercivall] I just spent some time review this issue and I can
confirm that [~scottyaslan] analysis is spot on. Just to elaborate a little bit
SlickGrid supports configurable editors and controls for creating new rows. By
default, cells are editing inline and new rows are added by editing the last
row of the table. SlickGrid employs an optimized virtual scrolling model which
requires the current size of the table to always be known. Because new rows are
added by editing the last row of the table, it must close out the current
editor when resizing its available space.
Obviously requiring re-entry when the current editor is closed out is not
acceptable. I'm not sure if copying the current state when the editor is
destroyed will work. There's no clear condition to know when we would want to
copy it out (vs when the editor is closed via a Cancel click or an Escape
keypress) and subsequently when to restore from the copy instead of the current
value of the property from the data model. I'd like to offer a couple possible
solutions.
1) If editing, commit the change prior to invoking the resize. This would
prevent data loss but would likely commit the value before the user was done
editing. In order to restore the previous value, they would need to Cancel the
Processor configuration dialog. This wouldn't be desirable if other properties
were modified.
2) If editing, do not support the responsive resize of the table. The dialog
could still expand/contract but the columns in the table would not update. We
could trigger a resize once the editor was closed. I would probably lean to
this option. The only downside is the visual of an expanded dialog where the
columns did not fit to its container. Often, however, this wouldn't even be
noticeable since the editor will be covering this expanded area.
An improved solution could be considered if we wanted to swap out our data grid
implementation. However, 1 or 2 above could be implemented as a quick win.
Thoughts?
> Resizing browser closes property entry textbox
> ----------------------------------------------
>
> Key: NIFI-3217
> URL: https://issues.apache.org/jira/browse/NIFI-3217
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core UI
> Affects Versions: 1.1.0
> Reporter: Joseph Percivall
> Priority: Minor
>
> Steps to reproduce
> 1: Have processor on graph
> 2: Open processor config window
> 3: Click to edit the value of a property (opens the entry textbox)
> 4: With the textbox open, resize the Browser Window
> 5: See the textbox automatically close
> Preferably, this should instead stay open.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)