Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2728
  
    OK, I've been doing some tests against a Postgres database and everything 
is working as I'd expect. I've only one minor feedback regarding the property 
description.
    
    > This property should only be used when the default queries are not 
performing well, when there is no maximum-value column or a single 
maximum-value column whose type can be coerced to a long integer (i.e. not date 
or timestamp), and the column values are evenly distributed and not sparse, for 
best performance.
    
    I'd just add something regarding the "and the column values are evenly 
distributed and not sparse": I'd say that if this condition is not met, it 
could generate a lot of flow files (and back-pressure won't apply), and a lot 
of the generated queries would lead to query execution with no returned rows.
    
    Not saying this should be added in the property description, but it could 
be something nice to add/mention in an "additional details" page?
    
    That's really minor and can be ignored. Overall I'm a +1 on this PR and can 
merge whenever that's OK for you.


---

Reply via email to