[ 
https://issues.apache.org/jira/browse/NIFI-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506199#comment-16506199
 ] 

ASF GitHub Bot commented on NIFI-5278:
--------------------------------------

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2768#discussion_r194108434
  
    --- Diff: 
nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/TestExecuteSparkInteractiveSSL.java
 ---
    @@ -109,13 +109,15 @@ private static TestServer createServer() throws 
IOException {
         public void testSslSparkSession() throws Exception {
             addHandler(new LivyAPIHandler());
     
    -        runner.enqueue("print \"hello world\"");
    +        String code = "print \"hello world\" //'?!<>[]{}()$&*=%;.|_-\\";
    --- End diff --
    
    I think that adding a UT for the non-SSL case is enough, isn't it? There is 
no difference among SSL and non-SSL about escaping and the content IIUC.


> ExecuteSparkInteractive processor fails on code containing a quote
> ------------------------------------------------------------------
>
>                 Key: NIFI-5278
>                 URL: https://issues.apache.org/jira/browse/NIFI-5278
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Peter Toth
>            Priority: Major
>
> ExecuteSparkInteractive usesĀ 
> org.apache.commons.lang.StringEscapeUtils.escapeJavaScript() which results 
> quotes to be escaped as \'. This breaks JSON payload of the Livy REST API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to