[
https://issues.apache.org/jira/browse/NIFI-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506196#comment-16506196
]
ASF GitHub Bot commented on NIFI-5278:
--------------------------------------
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2768#discussion_r194108030
--- Diff:
nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/TestExecuteSparkInteractive.java
---
@@ -85,16 +85,17 @@ private static TestServer createServer() throws
IOException {
@Test
public void testSparkSession() throws Exception {
-
addHandler(new LivyAPIHandler());
- runner.enqueue("print \"hello world\"");
+ String code = "print \"hello world\" //'?!<>[]{}()$&*=%;.|_-\\";
--- End diff --
instead of changing the existing UT, what about creating a new one for this
specific case? It is good that every UT has very little scope so that failures
can clearly indicate to the developer what he/she broke applying a patch...
> ExecuteSparkInteractive processor fails on code containing a quote
> ------------------------------------------------------------------
>
> Key: NIFI-5278
> URL: https://issues.apache.org/jira/browse/NIFI-5278
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Peter Toth
> Priority: Major
>
> ExecuteSparkInteractive uses
> org.apache.commons.lang.StringEscapeUtils.escapeJavaScript() which results
> quotes to be escaped as \'. This breaks JSON payload of the Livy REST API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
