ASF GitHub Bot commented on NIFI-5258:

GitHub user thenatog opened a pull request:


    NIFI-5258 - Changed addHeader to setHeader which stops X-Frame-Option…

    …s being added twice to responses. Added unit test.
    Thank you for submitting a contribution to Apache NiFi.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    - [X] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
    - [] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thenatog/nifi NIFI-5258-PR

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2791
commit 0a9a9805f24949252bc8eb2a94b238a03fbcef46
Author: thenatog <thenatog@...>
Date:   2018-06-13T21:05:57Z

    NIFI-5258 - Changed addHeader to setHeader which stops X-Frame-Options 
being added twice to responses. Added unit test.


> Improve handling of response headers for consistent application
> ---------------------------------------------------------------
>                 Key: NIFI-5258
>                 URL: https://issues.apache.org/jira/browse/NIFI-5258
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.6.0
>            Reporter: Andy LoPresto
>            Assignee: Nathan Gough
>            Priority: Minor
>              Labels: http, response
> Some response headers are not set consistently (missing or duplicated) on the 
> different web contexts. Enforce consistent behavior. 

This message was sent by Atlassian JIRA

Reply via email to