[
https://issues.apache.org/jira/browse/MINIFICPP-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522370#comment-16522370
]
ASF GitHub Bot commented on MINIFICPP-427:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197824984
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -115,14 +121,35 @@ class PublishKafka: public core::Processor {
buffer.reserve(max_seg_size_);
read_size_ = 0;
status_ = 0;
+ rd_kafka_resp_err_t err;
+
+ for (auto kv : flowFile_->getAttributes()) {
+ if (regex_match(kv.first, attributeNameRegex_)) {
+ if (!hdrs) {
+ hdrs = rd_kafka_headers_new(8);
--- End diff --
Was eight randomly chosen? If not please add a comment for any maintainers
to understand why you chose this number -- even if any number can be added or
removed per their API.
> Add headers support in PublishKafka
> -----------------------------------
>
> Key: MINIFICPP-427
> URL: https://issues.apache.org/jira/browse/MINIFICPP-427
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Pierre Villard
> Assignee: Dustin Rodrigues
> Priority: Major
>
> Would be nice to add headers support in PublishKafka (assuming Kafka 0.11+)
> in order to preserve attributes of the flow files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
