Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197976891
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
I know I can be a nitpicker sometimes on pull requests just to try to bring
stuff to attention to make sure it's what was intended. :) I have used `$VAR`
but I don't think I have ever used `${VAR}` in a Dockerfile.
---
