Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/130#discussion_r197978101
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -34,6 +34,8 @@ RUN mkdir -p $MINIFI_HOME
RUN apk --no-cache add curl
+ADD sh/ ${MINIFI_BASE_DIR}/scripts/
--- End diff --
I was curious and looked it up as well. I found the correct answer for
Dockerfile syntax here:
https://docs.docker.com/engine/reference/builder/#environment-replacement
> Environment variables are notated in the Dockerfile either with
$variable_name or ${variable_name}. They are treated equivalently and the brace
syntax is typically used to address issues with variable names with no
whitespace, like ${foo}_bar
Good eye, and I agree it's always better to point something out on reviews.
Everyone sees things slightly differently, and even if "correct" functionally,
it may not be the author's intention. Thanks!
---
