Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2841#discussion_r200381807
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/PasswordBasedEncryptor.java
 ---
    @@ -121,8 +122,8 @@ public void process(final InputStream in, final 
OutputStream out) throws IOExcep
                 byte[] salt;
                 try {
                     // NiFi legacy code determined the salt length based on 
the cipher block size
    -                if (cipherProvider instanceof NiFiLegacyCipherProvider) {
    -                    salt = ((NiFiLegacyCipherProvider) 
cipherProvider).readSalt(encryptionMethod, in);
    +                if (cipherProvider instanceof 
org.apache.nifi.security.util.crypto.NiFiLegacyCipherProvider) {
    --- End diff --
    
    This pattern is repeated a few times, is there a way to reduce the 
repetition?


---

Reply via email to