Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2841#discussion_r201202337
--- Diff:
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
---
@@ -107,12 +102,9 @@
*
* @return a Transaction to use for sending or receiving data, or
* <code>null</code> if all nodes are penalized.
- * @throws org.apache.nifi.remote.exception.HandshakeException he
- * @throws org.apache.nifi.remote.exception.PortNotRunningException
pnre
- * @throws IOException ioe
- * @throws org.apache.nifi.remote.exception.UnknownPortException upe
+ * @throws IOException if unable to determine the identifier of the
port
*/
- Transaction createTransaction(TransferDirection direction) throws
HandshakeException, PortNotRunningException, ProtocolException,
UnknownPortException, IOException;
--- End diff --
I agree; will revert this change. I think opening a separate Jira to
discuss error handling (and enforcing consistent behavior across the
application) is a good idea.
---
