[ 
https://issues.apache.org/jira/browse/NIFI-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560185#comment-16560185
 ] 

ASF GitHub Bot commented on NIFI-5469:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2922#discussion_r205879465
  
    --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
    @@ -2083,11 +2187,11 @@ Once these State Providers have been configured in 
the _state-management.xml_ fi
     referenced by their identifiers.
     
     By default, the Local State Provider is configured to be a 
`WriteAheadLocalStateProvider` that persists the data to the
    -_$NIFI_HOME/state/local_ directory. The default Cluster State Provider is 
configured to be a `ZooKeeperStateProvider`. The default
    +`$NIFI_HOME/state/local` directory. The default Cluster State Provider is 
configured to be a `ZooKeeperStateProvider`. The default
     ZooKeeper-based provider must have its `Connect String` property populated 
before it can be used. It is also advisable, if multiple NiFi instances
     will use the same ZooKeeper instance, that the value of the `Root Node` 
property be changed. For instance, one might set the value to
     `/nifi/<team name>/production`. A `Connect String` takes the form of comma 
separated <host>:<port> tuples, such as
    -my-zk-server1:2181,my-zk-server2:2181,my-zk-server3:2181. In the event a 
port is not specified for any of the hosts, the ZooKeeper default of
    +my-zk-server1:2181,`my-zk-server2:2181,my-zk-server3:2181`. In the event a 
port is not specified for any of the hosts, the ZooKeeper default of
    --- End diff --
    
    I think the initial backtick should go before `my-zk-server1:2181`, so:
    
    ```
    `my-zk-server1:2181,my-zk-server2:2181,my-zk-server3:2181`
    ```


> Edits needed for LDAP and Kerberos login identity provider sections in Admin 
> Guide
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-5469
>                 URL: https://issues.apache.org/jira/browse/NIFI-5469
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Documentation &amp; Website
>            Reporter: Andrew Lim
>            Assignee: Andrew Lim
>            Priority: Minor
>
> Going through the Authentication and Authorization sections of the Admin 
> Guide, I noticed the following improvements could be made:
>  * Removed “Kerberos Config File” property from kerberos-provider login 
> identity provider (this was done because the same property exists in 
> nifi.properties)
>  * Corrected the "LDAP-based Users/Groups Referencing User Attribute” login 
> identity provider example to refer to “member uid"
>  * Added titles to login identity provider examples for improved 
> readability/search
>  * Changed UserGroupProvider property examples from bulleted lists to tables
> Also, text formatting for references to config files, directories, etc.  need 
> to be made consistent.  For example, config files like _nifi.properties_, 
> _authorizers.xml_ should be italicized.  Directories, properties and default 
> values for properties should be monospaced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to