[ 
https://issues.apache.org/jira/browse/NIFI-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560192#comment-16560192
 ] 

ASF GitHub Bot commented on NIFI-5469:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2922#discussion_r205880240
  
    --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
    @@ -2434,82 +2538,82 @@ Before you begin, confirm that:
     +
     |====
     |*Required Information*|*Description*
    -|Source ZooKeeper hostname (*sourceHostname*)|The hostname must be one of 
the hosts running in the ZooKeeper ensemble, which can be found in <NiFi 
installation dir>/conf/zookeeper.properties.  Any of the hostnames declared in 
the *server.N* properties can be used.
    -|Destination ZooKeeper hostname (*destinationHostname*)|The hostname must 
be one of the hosts running in the ZooKeeper ensemble, which can be found in 
<NiFi installation dir>/conf/zookeeper.properties.  Any of the hostnames 
declared in the *server.N* properties can be used.
    -|Source ZooKeeper port (*sourceClientPort*)|This can be found in 
*zookeeper.properties* of the <NiFi installation 
dir>/conf/zookeeper.properties.  The port is specified in the *clientPort* 
property.
    -|Destination ZooKeeper port (*destinationClientPort*)|This can be found in 
*zookeeper.properties* of the <NiFi installation 
dir>/conf/zookeeper.properties.  The port is specified in the *clientPort* 
property.
    +|Source ZooKeeper hostname (*sourceHostname*)|The hostname must be one of 
the hosts running in the ZooKeeper ensemble, which can be found in _<NiFi 
installation dir>/conf/zookeeper.properties_.  Any of the hostnames declared in 
the *server.N* properties can be used.
    --- End diff --
    
    Should all these bold *propertyNames* be `code formatted` instead?


> Edits needed for LDAP and Kerberos login identity provider sections in Admin 
> Guide
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-5469
>                 URL: https://issues.apache.org/jira/browse/NIFI-5469
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Documentation &amp; Website
>            Reporter: Andrew Lim
>            Assignee: Andrew Lim
>            Priority: Minor
>
> Going through the Authentication and Authorization sections of the Admin 
> Guide, I noticed the following improvements could be made:
>  * Removed “Kerberos Config File” property from kerberos-provider login 
> identity provider (this was done because the same property exists in 
> nifi.properties)
>  * Corrected the "LDAP-based Users/Groups Referencing User Attribute” login 
> identity provider example to refer to “member uid"
>  * Added titles to login identity provider examples for improved 
> readability/search
>  * Changed UserGroupProvider property examples from bulleted lists to tables
> Also, text formatting for references to config files, directories, etc.  need 
> to be made consistent.  For example, config files like _nifi.properties_, 
> _authorizers.xml_ should be italicized.  Directories, properties and default 
> values for properties should be monospaced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to