[
https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567675#comment-16567675
]
ASF GitHub Bot commented on NIFI-5484:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2934
NIFI-5484: Fixed PutHive3Streaming to use the Hive Metastore URI property
(to include multiple URIs)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5484
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2934
----
commit 84876b40a3b4efc1d613db74c89734ad31180617
Author: Matthew Burgess <mattyb149@...>
Date: 2018-08-03T01:39:48Z
NIFI-5484: Fixed PutHive3Streaming to use the Hive Metastore URI property
(to include multiple URIs)
----
> PutHive3Streaming ignores the Hive Metastore URI property value
> ---------------------------------------------------------------
>
> Key: NIFI-5484
> URL: https://issues.apache.org/jira/browse/NIFI-5484
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> The "Hive Metastore URI" property was added to the PutHive3Streaming
> processor as an easy way to specify the Hive Metastore location(s), rather
> than having to set the "hive.metastore.uris" property in a hive-site.xml (or
> other configuration file).
> However the value of this property is never set on the Hive Streaming API,
> and is thus ignored. This means you MUST have a config file with
> "hive.metastore.uris" set, or I believe it will either default to
> "thrift://localhost:9083" or cause an error.
> PutHive3Streaming should honor the setting of this property. In addition,
> because it can get the values from a config file, the property should not be
> required. If set, it should allow a comma-separated list of URIs (each URI
> should be validated), and that list should override any setting in any
> provided configuration resources.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
