[ 
https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568250#comment-16568250
 ] 

ASF GitHub Bot commented on NIFI-5484:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2934#discussion_r207559164
  
    --- Diff: 
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java
 ---
    @@ -390,6 +391,19 @@ public ValidationResult validate(final String subject, 
final String input, final
             }
         };
     
    +    public static final Validator URI_LIST_VALIDATOR = (subject, input, 
context) -> {
    +
    +        if (context.isExpressionLanguageSupported(subject) && 
context.isExpressionLanguagePresent(input)) {
    +            return new 
ValidationResult.Builder().subject(subject).input(input).explanation("Expression
 Language Present").valid(true).build();
    +        }
    +        Optional<ValidationResult> invalidUri = 
Arrays.stream(input.split(","))
    --- End diff --
    
    I believe the way this stream is set up that an input of empty string would 
be considered valid. 


> PutHive3Streaming ignores the Hive Metastore URI property value
> ---------------------------------------------------------------
>
>                 Key: NIFI-5484
>                 URL: https://issues.apache.org/jira/browse/NIFI-5484
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> The "Hive Metastore URI" property was added to the PutHive3Streaming 
> processor as an easy way to specify the Hive Metastore location(s), rather 
> than having to set the "hive.metastore.uris" property in a hive-site.xml (or 
> other configuration file).
> However the value of this property is never set on the Hive Streaming API, 
> and is thus ignored. This means you MUST have a config file with 
> "hive.metastore.uris" set, or I believe it will either default to 
> "thrift://localhost:9083" or cause an error.
> PutHive3Streaming should honor the setting of this property. In addition, 
> because it can get the values from a config file, the property should not be 
> required. If set, it should allow a comma-separated list of URIs (each URI 
> should be validated), and that list should override any setting in any 
> provided configuration resources.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to