Github user kevdoran commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/133#discussion_r208955444
  
    --- Diff: 
nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/LoggingEventHookProvider.java
 ---
    @@ -36,6 +36,10 @@ public void onConfigured(final 
ProviderConfigurationContext configurationContext
     
         @Override
         public void handle(final Event event) throws EventHookException {
    +
    +        // Purposely leaving off "handleEvent" logic as its assumed that 
everything should be logged.
    +        //handleEvent(event)
    --- End diff --
    
    but that contradicts the documentation of the shared property... again I 
think we need to discuss what the intention is and then implement the code to 
match


---

Reply via email to