Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/133#discussion_r209132775
  
    --- Diff: 
nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/AbstractEventHookProvider.java
 ---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry.provider.hook;
    +
    +import org.apache.commons.lang3.StringUtils;
    +import org.apache.nifi.registry.hook.EventHookProvider;
    +import org.apache.nifi.registry.hook.EventType;
    +import org.apache.nifi.registry.provider.ProviderConfigurationContext;
    +import org.apache.nifi.registry.provider.ProviderCreationException;
    +import org.springframework.util.CollectionUtils;
    +
    +import java.util.HashSet;
    +import java.util.Map;
    +import java.util.Set;
    +import java.util.regex.Matcher;
    +import java.util.regex.Pattern;
    +
    +public abstract class AbstractEventHookProvider
    --- End diff --
    
    This should be part of the provider api module right? If someone implements 
a custom event hook they shouldn't have to create a dependency on 
nifi-registry-framework.


---

Reply via email to