[
https://issues.apache.org/jira/browse/NIFI-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598619#comment-16598619
]
ASF GitHub Bot commented on NIFI-5282:
--------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2943#discussion_r214324506
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/AbstractGCSProcessor.java
---
@@ -88,6 +92,15 @@ protected StorageOptions
getServiceOptions(ProcessContext context, GoogleCredent
storageOptionsBuilder.setTransportOptions(HttpTransportOptions.newBuilder().setHttpTransportFactory(new
HttpTransportFactory() {
@Override
public HttpTransport create() {
+ if (!StringUtils.isBlank(proxyUser) &&
!StringUtils.isBlank(proxyPassword)) {
+ Authenticator authenticator = new Authenticator() {
+ public PasswordAuthentication
getPasswordAuthentication() {
+ return (new
PasswordAuthentication(proxyUser,
+ proxyPassword.toCharArray()));
+ }
+ };
+ Authenticator.setDefault(authenticator);
--- End diff --
We'd like to avoid setting default authenticator as it affect system wide.
ApacheHttpTransport can be used to add proxy authentication support. I will
update it in the new PR.
> GCPProcessor with HTTP Proxy with Authentication
> ------------------------------------------------
>
> Key: NIFI-5282
> URL: https://issues.apache.org/jira/browse/NIFI-5282
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.6.0
> Reporter: Julian Gimbel
> Assignee: Sivaprasanna Sethuraman
> Priority: Minor
>
> The [AbstractGCPProcessor
> |https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java]
> already accepts http proxy settings but it but be even better if it accepts
> authenticated proxies with user and password aswell.
> In the best case it would support the ProxyService introduced in
> [NIFI-4199|https://issues.apache.org/jira/projects/NIFI/issues/NIFI-4199] and
> all of its options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
