[
https://issues.apache.org/jira/browse/NIFI-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598617#comment-16598617
]
ASF GitHub Bot commented on NIFI-5282:
--------------------------------------
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2943#discussion_r214253576
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/credentials/factory/CredentialPropertyDescriptors.java
---
@@ -88,4 +88,22 @@ private CredentialPropertyDescriptors() {}
.description("The raw JSON containing a Service Account
keyfile.")
.sensitive(true)
.build();
+
+ public static final PropertyDescriptor PROXY_HOST = new
PropertyDescriptor
+ .Builder().name("gcp-proxy-host")
+ .displayName("Proxy host")
+ .description("IP or hostname of the proxy to be used")
+ .required(false)
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor PROXY_PORT = new
PropertyDescriptor
+ .Builder().name("gcp-proxy-port")
+ .displayName("Proxy port")
+ .description("Proxy port number")
+ .required(false)
+ .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+ .addValidator(StandardValidators.INTEGER_VALIDATOR)
+ .build();
--- End diff --
I will add ProxyConfigurationService support at
GCPCredentialControllerService. But by doing so, I will omit these controller
service level properties to configuration and implementation simpler, user will
set proxy related config only via ProxyConfigurationService.
> GCPProcessor with HTTP Proxy with Authentication
> ------------------------------------------------
>
> Key: NIFI-5282
> URL: https://issues.apache.org/jira/browse/NIFI-5282
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.6.0
> Reporter: Julian Gimbel
> Assignee: Sivaprasanna Sethuraman
> Priority: Minor
>
> The [AbstractGCPProcessor
> |https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java]
> already accepts http proxy settings but it but be even better if it accepts
> authenticated proxies with user and password aswell.
> In the best case it would support the ProxyService introduced in
> [NIFI-4199|https://issues.apache.org/jira/projects/NIFI/issues/NIFI-4199] and
> all of its options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
