Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3000#discussion_r218843724
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java
 ---
    @@ -236,6 +238,12 @@ public int select(final LsEntry entry) {
                             return LsEntrySelector.CONTINUE;
                         }
     
    +                    // if is a link and we're supposed to follow symlink
    +                    if (symlink && entry.getAttrs().isLink()) {
    +                        links.add(entry);
    +                        return LsEntrySelector.CONTINUE;
    +                    }
    +
    --- End diff --
    
    Same as before, wondering if it'd be better to avoid code duplication:
    ````java
                        if ( (recurse && entry.getAttrs().isDir()) || (symlink 
&& entry.getAttrs().isLink()) ) {
                             subDirs.add(entry);
                            return LsEntrySelector.CONTINUE;
                        }
    ````


---

Reply via email to