[
https://issues.apache.org/jira/browse/NIFI-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635526#comment-16635526
]
ASF GitHub Bot commented on NIFI-5656:
--------------------------------------
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/3043
NIFI-5656 Remove "Node Group" from the default FileAccessPolicyProvider
propert…
…er properties, extend the docs, add more logs to help debugging, add test
for the empty case.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pepov/nifi NIFI-5656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3043.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3043
----
commit 251f1c476eece342bd6be6b3c5d3d8c17248f5b5
Author: pepov <peterwilcsinszky@...>
Date: 2018-10-02T13:21:36Z
NIFI-5656 Remove "Node Group" from the default FileAccessPolicyProvider
properties, extend the docs, add more logs to help debugging, add test for the
empty case.
----
> Remove Node Group property from FileAccessPolicyProvider in the default case
> ----------------------------------------------------------------------------
>
> Key: NIFI-5656
> URL: https://issues.apache.org/jira/browse/NIFI-5656
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.8.0
> Reporter: Peter Wilcsinszky
> Assignee: Peter Wilcsinszky
> Priority: Major
> Fix For: 1.8.0
>
>
> The "Node Group" property was introduced to let configuring node policies
> easier in a more dynamic environment. This feature is a base for future
> custom UserGroupProviders to provide a Group and the list of contained nodes
> dynamically. However in it's current form (if left empty) will throw an
> exception that would end in a confusing user experience as NiFi will fail to
> start.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
