[ 
https://issues.apache.org/jira/browse/NIFI-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635776#comment-16635776
 ] 

ASF GitHub Bot commented on NIFI-5656:
--------------------------------------

Github user pepov commented on the issue:

    https://github.com/apache/nifi/pull/3043
  
    I didn't think about considering an empty group as not set, but now I can 
see that initial admin is treated the same, so will update the PR to work like 
that.
    
    I used custom because I was thinking non of the available UGPs match that 
criteria. FileUserGroupProvider needs to be extended and wouldn't add that much 
benefit (nodes would still need to be added manually), however we may consider 
it if there are valid use cases.
    
    However you are right with LdapUserGroupProvider and I missed that it loads 
first time synchronously and starts the background thread right after, my bad 
and thanks for pointing it out. I referred to configuration time because I 
wanted to emphasize that the initial user/group loading should be done in the 
`onConfigured` method, not later.  Of course that is how it's done by the 
LdapUserGroupProvider already, without that, the initial admin setup wouldn't 
work reliable.


> Remove Node Group property from FileAccessPolicyProvider in the default case
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-5656
>                 URL: https://issues.apache.org/jira/browse/NIFI-5656
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.8.0
>            Reporter: Peter Wilcsinszky
>            Assignee: Peter Wilcsinszky
>            Priority: Major
>             Fix For: 1.8.0
>
>
> The "Node Group" property was introduced to let configuring node policies 
> easier in a more dynamic environment. This feature is a base for future 
> custom UserGroupProviders to provide a Group and the list of contained nodes 
> dynamically. However in it's current form (if left empty) will throw an 
> exception that would end in a confusing user experience as NiFi will fail to 
> start.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to