Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2947#discussion_r222184009
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FileSystemSwapManager.java
---
@@ -70,9 +71,8 @@
*/
public class FileSystemSwapManager implements FlowFileSwapManager {
- public static final int MINIMUM_SWAP_COUNT = 10000;
- private static final Pattern SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+\\.swap");
- private static final Pattern TEMP_SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+\\.swap\\.part");
+ private static final Pattern SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+(\\..*?)?\\.swap");
+ private static final Pattern TEMP_SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+(\\..*?)?\\.swap\\.part");
--- End diff --
I can't find a clear intent to change this regex. Is the captured group
`(\\..*?)?` used somewhere? Or is it just for performance improvement?
Either way, I think we need '?' after the '+', too:
- Current: `\d+-.+(\..*?)?\.swap`
- Suggestion: `\d+-.+?(\..*?)?\.swap`
---
