Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2947#discussion_r222330395
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FileSystemSwapManager.java
---
@@ -70,9 +71,8 @@
*/
public class FileSystemSwapManager implements FlowFileSwapManager {
- public static final int MINIMUM_SWAP_COUNT = 10000;
- private static final Pattern SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+\\.swap");
- private static final Pattern TEMP_SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+\\.swap\\.part");
+ private static final Pattern SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+(\\..*?)?\\.swap");
+ private static final Pattern TEMP_SWAP_FILE_PATTERN =
Pattern.compile("\\d+-.+(\\..*?)?\\.swap\\.part");
--- End diff --
I don't believe the extra ? is necessary. Either would likely work. I have,
however, tested and verified the one that is in the PR. The point of changing
it was that the naming convention for swap files changed from
"<timestamp>-<uuid>.swap" to "<timestamp>-<uuid>.<partition_name>.swap". The
"<partition_name>." is optional in order to maintain backward compatibility in
case there are swap files created from a previous version of nifi.
---
