[
https://issues.apache.org/jira/browse/MINIFICPP-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655272#comment-16655272
]
ASF GitHub Bot commented on MINIFICPP-647:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226320573
--- Diff: python/minifi/__init__.py ---
@@ -66,9 +66,9 @@ def setBase(self, proc):
def get(self, session):
ff = self._minifi.get(self._instance.get_instance(),self._flow,
session)
if ff:
--- End diff --
Yeah i tend to avoid ternary operators in general since my experience with
production code has always led maintainers at some point to result in error.
Looks great -- but more errors than positives in my experience I'm afraid.
> Deprecate functions in API that pass char* in favor of those more strongly
> typed
> --------------------------------------------------------------------------------
>
> Key: MINIFICPP-647
> URL: https://issues.apache.org/jira/browse/MINIFICPP-647
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Priority: Blocker
> Labels: CAPI
> Fix For: 0.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
