[
https://issues.apache.org/jira/browse/MINIFICPP-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655584#comment-16655584
]
ASF GitHub Bot commented on MINIFICPP-647:
------------------------------------------
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226386769
--- Diff: libminifi/src/capi/api.cpp ---
@@ -57,38 +57,28 @@ class DirectoryConfiguration {
}
};
-nifi_port *create_port(const char *port) {
- if (nullptr == port)
- return nullptr;
- nifi_port *p = new nifi_port();
- p->port_id = new char[strlen(port) + 1];
- memset(p->port_id, 0x00, strlen(port) + 1);
- strncpy(p->port_id, port, strlen(port));
- return p;
-}
-
-int free_port(nifi_port *port) {
- if (port == nullptr)
- return -1;
- delete[] port->port_id;
- delete port;
- return 0;
-}
-
/**
* Creates a NiFi Instance from the url and output port.
* @param url http URL for NiFi instance
* @param port Remote output port.
+ * @Deprecated for 0.6.0 in favor of
--- End diff --
Well rereading the deprecation note, it makes more sense than my first take
on things. I guess I anticipate this maybe being problematic in the near
future when both would reach the 1.0 mark. I know there is connectedness
between the both the capi and the agent itself but would almost prefer just
saying that it was done for 0.02. I could see the API reaching a certain level
of maturity where the agent would continue to evolve but the API itself is
fairly static.
As a general thought, we could probably use some exploration of minifi
cpp's versioning/support guarantees especially as this API gets built out.
> Deprecate functions in API that pass char* in favor of those more strongly
> typed
> --------------------------------------------------------------------------------
>
> Key: MINIFICPP-647
> URL: https://issues.apache.org/jira/browse/MINIFICPP-647
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Priority: Blocker
> Labels: CAPI
> Fix For: 0.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
