[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666597#comment-16666597
]
ASF GitHub Bot commented on MINIFICPP-653:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r228769742
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -40,21 +39,24 @@ def __init__(self, output_validator):
# Create test input/output directories
test_cluster_id = str(uuid.uuid4())
+
+ self.segfault = False
self.tmp_test_output_dir = '/tmp/.nifi-test-output.' +
test_cluster_id
self.tmp_test_input_dir = '/tmp/.nifi-test-input.' +
test_cluster_id
self.tmp_test_resources_dir = '/tmp/.nifi-test-resources.' +
test_cluster_id
logging.info('Creating tmp test input dir: %s',
self.tmp_test_input_dir)
- os.makedirs(self.tmp_test_input_dir, mode=0777)
+ os.makedirs(self.tmp_test_input_dir)
logging.info('Creating tmp test output dir: %s',
self.tmp_test_output_dir)
- os.makedirs(self.tmp_test_output_dir, mode=0777)
+ os.makedirs(self.tmp_test_output_dir)
logging.info('Creating tmp test resource dir: %s',
self.tmp_test_resources_dir)
- os.makedirs(self.tmp_test_resources_dir, mode=0777)
+ os.makedirs(self.tmp_test_resources_dir)
# Point output validator to ephemeral output dir
self.output_validator = output_validator
- output_validator.set_output_dir(self.tmp_test_output_dir)
+ if isinstance(output_validator, SingleFileOutputValidator):
+ output_validator.set_output_dir(self.tmp_test_output_dir)
--- End diff --
thanks for pointing this out! ! I'll run re-indent.
> Log message will segfault client if no content produced
> -------------------------------------------------------
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
