[
https://issues.apache.org/jira/browse/MINIFICPP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669726#comment-16669726
]
ASF GitHub Bot commented on MINIFICPP-653:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229595113
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -142,7 +147,7 @@ def check_output(self, timeout=5):
self.wait_for_output(timeout)
self.log_nifi_output()
- return self.output_validator.validate()
+ return self.output_validator.validate() & ~self.segfault
--- End diff --
I have hardly seen, but the question was meant to ask what do we plan to
achieve here.
I just run through the code to understand what's going on here, this if
fine, but using logical expressions are way more _pythonic_ to achieve the same:
```
return self.output_validator.validate() and not self.segfault
```
> Log message will segfault client if no content produced
> -------------------------------------------------------
>
> Key: MINIFICPP-653
> URL: https://issues.apache.org/jira/browse/MINIFICPP-653
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Blocker
>
> Log message will segfault client if no content produced
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
