Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229015052
  
    --- Diff: libminifi/include/capi/Plan.h ---
    @@ -16,6 +16,8 @@
      * limitations under the License.
      */
     
    +#pragma once
    --- End diff --
    
    The more I think about this for a public, open source project, we should 
probably avoid pragma once given that it's implementation defined and not 
language spec. We don't control all compiler variants, especially for what will 
be this portion of the API. I realize it's nearly "universally supported" but 
it seems like an unnecessary risk, albeit small. 


---

Reply via email to