[GitHub] nifi-minifi-cpp pull request #429: MINIFICPP-654 - C API: failure callback i...

[phrocker]

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229015497
  
    --- Diff: libminifi/include/capi/Plan.h ---
    @@ -46,11 +48,50 @@
     #include "capi/cstructs.h"
     #include "capi/api.h"
     
    +enum FailureStrategy { AS_IS, ROLLBACK };
    +
    +bool intToFailureStragey(int in, FailureStrategy *out);
    --- End diff --
    
    *spelling.
    Is this something to be used in C? Perhaps we should avoid booleans? 
stdbool wasn't introduced until C99..


---