[
https://issues.apache.org/jira/browse/NIFI-5770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670090#comment-16670090
]
ASF GitHub Bot commented on NIFI-5770:
--------------------------------------
GitHub user bdesert opened a pull request:
https://github.com/apache/nifi/pull/3117
NIFI-5770 Fix Memory Leak in ExecuteScript on Jython
Moved module appending (aka classpath in python) into init stage instead of
running each time onTrigger.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bdesert/nifi NIFI-5770_ExecuteScript
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3117
----
commit e6837c81e84b2d7fa29b020c8192b4a2a9783e18
Author: Ed B <eberezitsky@...>
Date: 2018-10-31T13:10:27Z
NIFI-5770 Fix Memory Leak in ExecuteScript on Jython
Moved module appending (aka classpath in python) into init stage instead of
running each time onTrigger.
----
> Memory Leak in ExecuteScript
> ----------------------------
>
> Key: NIFI-5770
> URL: https://issues.apache.org/jira/browse/NIFI-5770
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.8.0
> Reporter: Ed Berezitsky
> Assignee: Ed Berezitsky
> Priority: Major
> Labels: features, performance
> Attachments: ExecuteScriptMemLeak.xml, jython_modules.zip
>
>
> ExecuteScript with Jython engine has memory leak.
> It uses JythonScriptEngineConfigurator class to configure jython execution
> environment.
> The problem is in the line:
> {code:java}
> engine.eval("sys.path.append('" + modulePath + "')");{code}
> There is no check if a module has already been added previously.
> As a result, with each execution (onTrigger), string value of module
> property is being appended, and never reset.
> Although InvokeScriptedProcessor uses the same engine configurator, memory
> leak is not reproducable in it,
> because ISP builds the engine and compile the code only once (and rebuilds
> every time any relevant property is changed).
> Attached:
> * template with a flow to reproduce the bug
> * simple python modules (to be unpacked under /tmp)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
