[ 
https://issues.apache.org/jira/browse/NIFI-5770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671757#comment-16671757
 ] 

ASF subversion and git services commented on NIFI-5770:
-------------------------------------------------------

Commit 89295e52ef33963e97f14e9aa207a93d71acdfb6 in nifi's branch 
refs/heads/master from Ed B
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=89295e5 ]

NIFI-5770 Fix Memory Leak in ExecuteScript on Jython

Moved module appending (aka classpath in python) into init stage instead of 
running each time onTrigger.

Signed-off-by: Matthew Burgess <mattyb...@apache.org>

This closes #3117


> Memory Leak in ExecuteScript
> ----------------------------
>
>                 Key: NIFI-5770
>                 URL: https://issues.apache.org/jira/browse/NIFI-5770
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Ed Berezitsky
>            Assignee: Ed Berezitsky
>            Priority: Major
>              Labels: performance
>             Fix For: 1.9.0
>
>         Attachments: 3117.patch, ExecuteScriptMemLeak.xml, jython_modules.zip
>
>
> ExecuteScript with Jython engine has memory leak.
>  It uses JythonScriptEngineConfigurator class to configure jython execution 
> environment.
>  The problem is in the line:
> {code:java}
> engine.eval("sys.path.append('" + modulePath + "')");{code}
> There is no check if a module has already been added previously.
>  As a result, with each execution (onTrigger), string value of module 
> property is being appended, and never reset.
> Although InvokeScriptedProcessor uses the same engine configurator, memory 
> leak is not reproducable in it,
>  because ISP builds the engine and compile the code only once (and rebuilds 
> every time any relevant property is changed).
>  Attached:
>  * template with a flow to reproduce the bug
>  * simple python modules (to be unpacked under /tmp)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to