Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3122#discussion_r230022659
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLogMessage.java
 ---
    @@ -57,7 +57,7 @@ MockComponentLog getMockComponentLog() {
         public void before() throws InitializationException {
             testableLogMessage = new TestableLogMessage();
             runner = TestRunners.newTestRunner(testableLogMessage);
    -
    +        runner.setValidateExpressionUsage(false);
    --- End diff --
    
    I disagree with this change: disabling the expression usage validation 
should be avoided as much as possible and, if I recall correctly, is only 
necessary in very specific edge cases. Instead of disabling the validation, I'd 
fix the original issue by removing ``.evaluateAttributeExpressions(flowFile)`` 
on L129 in LogMessage since it does not make sense. Once it's fixed, I'm a +1 
and can merge to master. Feel free to squash your commits. Thanks!


---

Reply via email to