[
https://issues.apache.org/jira/browse/MINIFICPP-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675343#comment-16675343
]
ASF GitHub Bot commented on MINIFICPP-648:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230801807
--- Diff: libminifi/CMakeLists.txt ---
@@ -141,11 +141,14 @@ endif()
SET (LIBMINIFI core-minifi PARENT_SCOPE)
if (ENABLE_PYTHON)
-if (NOT APPLE)
#### shared
add_library(core-minifi-shared SHARED ${SOURCES})
-target_link_libraries(core-minifi-shared ${CMAKE_DL_LIBS} uuid-shared
yaml-cpp)
+if (APPLE)
--- End diff --
I strongly agree, but in that case Python related tests (the ones that
don't transport, just create instance, processor, flow files) could also be
added to cover that.
> add processor and add processor with linkage nomenclature is confusing
> ----------------------------------------------------------------------
>
> Key: MINIFICPP-648
> URL: https://issues.apache.org/jira/browse/MINIFICPP-648
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Arpad Boda
> Priority: Blocker
> Labels: CAPI
> Fix For: 0.6.0
>
>
> add_processor should be changed to always add a processor with linkage
> without compelling documentation as why this exists.. As a result we will
> need to add a create_processor function to create one without adding it to
> the flow ( certain use cases where a flow isn't needed such as invokehttp or
> listenhttp ) this can be moved to 0.7.0 if we tag before recent commits.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
