[ https://issues.apache.org/jira/browse/MINIFICPP-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675351#comment-16675351 ]
ASF GitHub Bot commented on MINIFICPP-648: ------------------------------------------ Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230803774 --- Diff: libminifi/CMakeLists.txt --- @@ -141,11 +141,14 @@ endif() SET (LIBMINIFI core-minifi PARENT_SCOPE) if (ENABLE_PYTHON) -if (NOT APPLE) #### shared add_library(core-minifi-shared SHARED ${SOURCES}) -target_link_libraries(core-minifi-shared ${CMAKE_DL_LIBS} uuid-shared yaml-cpp) +if (APPLE) --- End diff -- Indeed -- https://issues.apache.org/jira/browse/MINIFICPP-660 already exists. I've pre-empted that in favor of CoAP, but should get back to that soon. Python is kind of WIP. I do have some tests from that branch that cover what you are talking about. I'll try and re-surface them as soon as I get away from CoAP. > add processor and add processor with linkage nomenclature is confusing > ---------------------------------------------------------------------- > > Key: MINIFICPP-648 > URL: https://issues.apache.org/jira/browse/MINIFICPP-648 > Project: NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Mr TheSegfault > Assignee: Arpad Boda > Priority: Blocker > Labels: CAPI > Fix For: 0.6.0 > > > add_processor should be changed to always add a processor with linkage > without compelling documentation as why this exists.. As a result we will > need to add a create_processor function to create one without adding it to > the flow ( certain use cases where a flow isn't needed such as invokehttp or > listenhttp ) this can be moved to 0.7.0 if we tag before recent commits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)