[
https://issues.apache.org/jira/browse/MINIFICPP-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679690#comment-16679690
]
ASF GitHub Bot commented on MINIFICPP-648:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231865178
--- Diff: nanofi/include/cxx/CallbackProcessor.h ---
@@ -65,7 +65,7 @@ class CallbackProcessor : public core::Processor {
public:
- void setCallback(void *obj,std::function<void(processor_session*)>
ontrigger_callback) {
+ void setCallback(void *obj,std::function<void(core::ProcessSession*)>
ontrigger_callback) {
--- End diff --
It's been a while since I've looked at that work, but did the python
bindings call this correctly when running python processors?
> add processor and add processor with linkage nomenclature is confusing
> ----------------------------------------------------------------------
>
> Key: MINIFICPP-648
> URL: https://issues.apache.org/jira/browse/MINIFICPP-648
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Arpad Boda
> Priority: Blocker
> Labels: CAPI
> Fix For: 0.6.0
>
>
> add_processor should be changed to always add a processor with linkage
> without compelling documentation as why this exists.. As a result we will
> need to add a create_processor function to create one without adding it to
> the flow ( certain use cases where a flow isn't needed such as invokehttp or
> listenhttp ) this can be moved to 0.7.0 if we tag before recent commits.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
