[
https://issues.apache.org/jira/browse/MINIFICPP-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679741#comment-16679741
]
ASF GitHub Bot commented on MINIFICPP-648:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231879717
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -89,6 +93,39 @@ nifi_instance *create_instance(const char *url,
nifi_port *port) {
return instance;
}
+standalone_processor *create_processor(const char *name) {
+ static int proc_counter = 0;
+ auto ptr = ExecutionPlan::createProcessor(name, name);
+ if (!ptr) {
+ return nullptr;
+ }
+ if (standalone_instance == nullptr) {
+ nifi_port port;
--- End diff --
Created with dummy value. Do you think having a valid input port is valid
usecase for an instance we don't even expose? (As we use it to "store"
standalone processors)
> add processor and add processor with linkage nomenclature is confusing
> ----------------------------------------------------------------------
>
> Key: MINIFICPP-648
> URL: https://issues.apache.org/jira/browse/MINIFICPP-648
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Arpad Boda
> Priority: Blocker
> Labels: CAPI
> Fix For: 0.6.0
>
>
> add_processor should be changed to always add a processor with linkage
> without compelling documentation as why this exists.. As a result we will
> need to add a create_processor function to create one without adding it to
> the flow ( certain use cases where a flow isn't needed such as invokehttp or
> listenhttp ) this can be moved to 0.7.0 if we tag before recent commits.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
