[ 
https://issues.apache.org/jira/browse/NIFI-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681597#comment-16681597
 ] 

ASF GitHub Bot commented on NIFI-5718:
--------------------------------------

Github user patricker commented on the issue:

    https://github.com/apache/nifi/pull/3100
  
    @markap14, I agree that the class would be useful. Can you include a unit 
test that references it? As long as some piece of the PR legitimately 
references the class then I'm completely happy keeping it in and merging it, 
even with the `@Ignore` attribute, now that it's been explained to me.


> Performance degraded in ReplaceText processor
> ---------------------------------------------
>
>                 Key: NIFI-5718
>                 URL: https://issues.apache.org/jira/browse/NIFI-5718
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>         Attachments: Screen Shot 2018-10-17 at 10.55.53 AM.png
>
>
> NIFI-5711 addresses some licensing concerns in the NLKBufferedReader class.
> In doing so, however, it results in lower performance. The ReplaceText 
> processor is affected if the Evaluation Mode is set to Line-by-Line, and the 
> RouteText processor will also be affected. We should be able to match the 
> performance of the previous version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to