[
https://issues.apache.org/jira/browse/NIFI-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681951#comment-16681951
]
ASF GitHub Bot commented on NIFI-5718:
--------------------------------------
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/3100
+1 LGTM Ran all of the unit tests, looks good. Built it and ran it locally,
had no issues. I also ran a unit test that never got put in from the ticket
that started this whole journey,
https://issues.apache.org/jira/browse/NIFI-5689?focusedCommentId=16652020&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16652020,
no issues.
> Performance degraded in ReplaceText processor
> ---------------------------------------------
>
> Key: NIFI-5718
> URL: https://issues.apache.org/jira/browse/NIFI-5718
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Attachments: Screen Shot 2018-10-17 at 10.55.53 AM.png
>
>
> NIFI-5711 addresses some licensing concerns in the NLKBufferedReader class.
> In doing so, however, it results in lower performance. The ReplaceText
> processor is affected if the Evaluation Mode is set to Line-by-Line, and the
> RouteText processor will also be affected. We should be able to match the
> performance of the previous version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
