[ 
https://issues.apache.org/jira/browse/MINIFICPP-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688284#comment-16688284
 ] 

ASF GitHub Bot commented on MINIFICPP-667:
------------------------------------------

Github user arpadboda commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233910142
  
    --- Diff: nanofi/include/core/cstructs.h ---
    @@ -76,6 +80,12 @@ typedef struct {
      * ##################################################################
      */
     
    +typedef struct{
    +  char *key;
    --- End diff --
    
    Can we have this as const char *?
    A bit better user experience if you can write something like 
    ```
    key_value.key = "some string" 
    ```


> Create Structural definitions for moving away from C++ classes
> --------------------------------------------------------------
>
>                 Key: MINIFICPP-667
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-667
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>    Affects Versions: nanofi
>            Reporter: Mr TheSegfault
>            Assignee: Mr TheSegfault
>            Priority: Major
>             Fix For: 0.6.0
>
>
> Create Structural definitions for moving away from C++ classes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to