[
https://issues.apache.org/jira/browse/MINIFICPP-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688292#comment-16688292
]
ASF GitHub Bot commented on MINIFICPP-667:
------------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233911949
--- Diff: nanofi/include/core/cstructs.h ---
@@ -76,6 +80,12 @@ typedef struct {
* ##################################################################
*/
+typedef struct{
+ char *key;
--- End diff --
I'll add that I'm not against this, but the code pointer's management was a
little different. Again, I'll take a look at if this makes sense. core will be
things that don't reflect a user experience though. That is code that's not
part of our public API.
> Create Structural definitions for moving away from C++ classes
> --------------------------------------------------------------
>
> Key: MINIFICPP-667
> URL: https://issues.apache.org/jira/browse/MINIFICPP-667
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Affects Versions: nanofi
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Major
> Fix For: 0.6.0
>
>
> Create Structural definitions for moving away from C++ classes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)