[ 
https://issues.apache.org/jira/browse/NIFIREG-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701052#comment-16701052
 ] 

ASF GitHub Bot commented on NIFIREG-211:
----------------------------------------

Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/148#discussion_r236850477
  
    --- Diff: 
nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionRepositoryResource.java
 ---
    @@ -0,0 +1,378 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.registry.web.api;
    +
    +import io.swagger.annotations.Api;
    +import io.swagger.annotations.ApiOperation;
    +import io.swagger.annotations.ApiParam;
    +import io.swagger.annotations.ApiResponse;
    +import io.swagger.annotations.ApiResponses;
    +import io.swagger.annotations.Authorization;
    +import io.swagger.annotations.Extension;
    +import io.swagger.annotations.ExtensionProperty;
    +import org.apache.nifi.registry.bucket.Bucket;
    +import org.apache.nifi.registry.bucket.BucketItem;
    +import org.apache.nifi.registry.event.EventService;
    +import org.apache.nifi.registry.extension.ExtensionBundleVersion;
    +import org.apache.nifi.registry.extension.repo.ExtensionRepoArtifact;
    +import org.apache.nifi.registry.extension.repo.ExtensionRepoBucket;
    +import org.apache.nifi.registry.extension.repo.ExtensionRepoGroup;
    +import org.apache.nifi.registry.extension.repo.ExtensionRepoVersion;
    +import org.apache.nifi.registry.extension.repo.ExtensionRepoVersionSummary;
    +import org.apache.nifi.registry.security.authorization.RequestAction;
    +import org.apache.nifi.registry.service.AuthorizationService;
    +import org.apache.nifi.registry.service.RegistryService;
    +import 
org.apache.nifi.registry.service.extension.ExtensionBundleVersionCoordinate;
    +import org.apache.nifi.registry.web.link.LinkService;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.stereotype.Component;
    +
    +import javax.ws.rs.Consumes;
    +import javax.ws.rs.GET;
    +import javax.ws.rs.Path;
    +import javax.ws.rs.PathParam;
    +import javax.ws.rs.Produces;
    +import javax.ws.rs.core.Link;
    +import javax.ws.rs.core.MediaType;
    +import javax.ws.rs.core.Response;
    +import javax.ws.rs.core.StreamingOutput;
    +import java.util.ArrayList;
    +import java.util.Set;
    +import java.util.SortedSet;
    +
    +@Component
    +@Path("/extensions/repo")
    +@Api(
    +        value = "extension_repository",
    +        description = "Interact with extension bundles via the hierarchy 
of bucket/group/artifact/version.",
    +        authorizations = { @Authorization("Authorization") }
    +)
    +public class ExtensionRepositoryResource extends 
AuthorizableApplicationResource {
    +
    +    public static final String CONTENT_DISPOSITION_HEADER = 
"content-disposition";
    +    private final RegistryService registryService;
    +    private final LinkService linkService;
    +
    +    @Autowired
    +    public ExtensionRepositoryResource(
    +            final RegistryService registryService,
    +            final LinkService linkService,
    +            final AuthorizationService authorizationService,
    +            final EventService eventService) {
    +        super(authorizationService, eventService);
    +        this.registryService = registryService;
    +        this.linkService = linkService;
    +    }
    +
    +    @GET
    +    @Consumes(MediaType.WILDCARD)
    +    @Produces(MediaType.APPLICATION_JSON)
    +    @ApiOperation(
    +            value = "Gets the names of the buckets the current user is 
authorized for in order to browse the repo by bucket",
    +            response = ExtensionRepoBucket.class,
    +            responseContainer = "List",
    +            extensions = {
    +                    @Extension(name = "access-policy", properties = {
    +                            @ExtensionProperty(name = "action", value = 
"read"),
    +                            @ExtensionProperty(name = "resource", value = 
"/buckets/{bucketId}") })
    +            }
    --- End diff --
    
    That sounds consistent with the getBuckets end-point, so I'll remove that.


> Add extension bundles as a type of versioned item
> -------------------------------------------------
>
>                 Key: NIFIREG-211
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-211
>             Project: NiFi Registry
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Major
>             Fix For: 0.4.0
>
>
> This ticket is to capture the work for adding extension bundles to NiFi 
> Registry.
> This work may require several follow on tickets, but at a high-level will 
> include some of the following:
> - Add a new type of item called an extension bundle, where each bundle
>  can contain one ore extensions or APIs
>  
>  - Support bundles for traditional NiFi (aka NARs) and also bundles for
>  MiNiFi CPP
>  
>  - Ability to upload the binary artifact for a bundle and extract the
>  metadata about the bundle, and metadata about the extensions contained
>  in the bundle (more on this later)
>  
>  - Provide a pluggable storage provider for saving the content of each
>  extension bundle so that we can have different implementations like
>  local fileysystem, S3, and other object stores
>  
>  - Provide a REST API for listing and retrieving available bundles,
>  integrate this into the registry Java client and NiFi CLI
> - Security considerations such as checksums and cryptographic signatures for 
> bundles



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to