[
https://issues.apache.org/jira/browse/NIFIREG-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703480#comment-16703480
]
ASF GitHub Bot commented on NIFIREG-211:
----------------------------------------
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/148#discussion_r237568373
--- Diff:
nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/extension/StandardExtensionService.java
---
@@ -188,13 +188,14 @@ public ExtensionBundleVersion
createExtensionBundleVersion(final String bucketId
// create the bundle version in the metadata db
final String userIdentity =
NiFiUserUtils.getNiFiUserIdentity();
+ final long bundleCreatedTime =
extensionBundle.getCreated().getTime();
final ExtensionBundleVersionMetadata versionMetadata = new
ExtensionBundleVersionMetadata();
versionMetadata.setId(UUID.randomUUID().toString());
versionMetadata.setExtensionBundleId(extensionBundle.getId());
versionMetadata.setBucketId(bucketIdentifier);
versionMetadata.setVersion(version);
- versionMetadata.setTimestamp(System.currentTimeMillis());
+ versionMetadata.setTimestamp(bundleCreatedTime);
--- End diff --
This works great when the bundle is being created with the first version
uploaded. But I noticed when subsequent versions are uploaded they are also
getting tagged with the same creation time. Given that we don't know what was
done in getOrCreateExtensionBundle, we might need to refactor the code above,
or... it might be better to just revert this change to always use currentTime
for the bundle version. I'm good with either
> Add extension bundles as a type of versioned item
> -------------------------------------------------
>
> Key: NIFIREG-211
> URL: https://issues.apache.org/jira/browse/NIFIREG-211
> Project: NiFi Registry
> Issue Type: Improvement
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Major
> Fix For: 0.4.0
>
>
> This ticket is to capture the work for adding extension bundles to NiFi
> Registry.
> This work may require several follow on tickets, but at a high-level will
> include some of the following:
> - Add a new type of item called an extension bundle, where each bundle
> can contain one ore extensions or APIs
>
> - Support bundles for traditional NiFi (aka NARs) and also bundles for
> MiNiFi CPP
>
> - Ability to upload the binary artifact for a bundle and extract the
> metadata about the bundle, and metadata about the extensions contained
> in the bundle (more on this later)
>
> - Provide a pluggable storage provider for saving the content of each
> extension bundle so that we can have different implementations like
> local fileysystem, S3, and other object stores
>
> - Provide a REST API for listing and retrieving available bundles,
> integrate this into the registry Java client and NiFi CLI
> - Security considerations such as checksums and cryptographic signatures for
> bundles
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
